ATDM: Simplify finding and using TrilinosConfig.cmake (#7125) #7126

bartlettroscoe · 2020-04-04T00:54:25Z

Addresses #7125

This pulls in a snapshot of TriBITS 'master' as well for recent changes.

eric-c-cyr · 2020-04-04T02:22:41Z

Roughly speaking (I will test tomorrow or sometime this weekend) the code that does what we discussed looks good to me. There is a lot of other stuff in this PR I don’t recognize as well, and am probably not qualified to review. That said, I did find something I had been looking for (though not looking very hard), the command to install gitdist!

…

Sent from my iPad On Apr 3, 2020, at 6:54 PM, Roscoe A. Bartlett <notifications@github.com> wrote: @bartlettroscoe<https://github.com/bartlettroscoe> requested your review on: #7126<#7126> ATDM: Simplify finding and using TrilinosConfig.cmake (#7125<#7125>). — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#7126 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHYSH52I6NHUC4QBP45X5LRK2AM7ANCNFSM4L4VN74Q>.

trilinos-autotester · 2020-04-05T05:58:03Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2020-04-05T06:12:33Z

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

Other jobs have been previously started - We must stop them...
Terminating Build ML: Adding some memory tracking to a test #6192 of Jenkins job Trilinos_pullrequest_gcc_4.8.4 on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Adjust set of 'sems-rhel7' builds (CDOFA-65) #6015 of Jenkins job Trilinos_pullrequest_intel_17.0.1 on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Reduce test problem sizes #4444 of Jenkins job Trilinos_pullrequest_gcc_4.9.3_SERIAL on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Tpetra crs matrix swap #4292 of Jenkins job Trilinos_pullrequest_gcc_7.2.0 on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build fix delegation in Piro::TrapezoidDecorator #481 of Jenkins job Trilinos_pullrequest_gcc_8.3.0 on Jenkins server at https://ascic-jenkins.sandia.gov

trilinos-autotester · 2020-04-05T09:01:37Z

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_cuda_9.2 to start: Total Wait = 603

Other jobs have been previously started - We must stop them...
Terminating Build More lightsaber driver updates #6193 of Jenkins job Trilinos_pullrequest_gcc_4.8.4 on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20191002_000631 branch to master #6016 of Jenkins job Trilinos_pullrequest_intel_17.0.1 on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Framework: Adding OMP_NUM_THREADS to PR Testing #4445 of Jenkins job Trilinos_pullrequest_gcc_4.9.3_SERIAL on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Disable Tpetra test for CUDA PR build #4293 of Jenkins job Trilinos_pullrequest_gcc_7.2.0 on Jenkins server at https://ascic-jenkins.sandia.gov
Terminating Build Set up robust portable pre-push and post-push CI tools and process based on the SEMS Dev Env #482 of Jenkins job Trilinos_pullrequest_gcc_8.3.0 on Jenkins server at https://ascic-jenkins.sandia.gov

trilinos-autotester · 2020-04-08T00:17:28Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2020-04-08T00:17:32Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

bartlettroscoe · 2020-04-08T00:18:51Z

@rppawlo, @eric-c-cyr, @jmgate, can one of you please re-approve this PR? I had resolve a merge conflict (that I don't understand why it existed) and now this commit involves just one commit to set the var Trilinos_ROOT. The addition of the var Trilinos_INSTALL_DIR in TriBITS got added as part of PR #7138. (See here)

trilinos-autotester · 2020-04-08T00:19:50Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 6237
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 6061
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Build Num: 4489
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Build Num: 4337
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Build Num: 526
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Build Num: 3856
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

Build Num: 229
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_python_2

Build Num: 2044
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_python_3

Build Num: 2055
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2020-04-08T00:23:14Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 6237
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 6061
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Build Num: 4489
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Build Num: 4337
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Build Num: 526
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Build Num: 3856
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

Build Num: 229
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_python_2

Build Num: 2044
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

Build Information

Test Name: Trilinos_pullrequest_python_3

Build Num: 2055
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	7126
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	7125-atdm-trilinos-root-install-dir
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`890cd44`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3cb3a8b`

CDash Test Results for PR# 7126.

trilinos-autotester · 2020-04-08T00:23:32Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

trilinos-autotester · 2020-04-08T00:23:39Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2020-04-08T11:17:32Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]!

trilinos-autotester · 2020-04-08T11:17:39Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2020-04-08T11:17:43Z

Merge on Pull Request# 7126: IS A SUCCESS - Pull Request successfully merged

bartlettroscoe added type: enhancement Issue is an enhancement, not a bug client: ATDM Any issue primarily impacting the ATDM project ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams labels Apr 4, 2020

bartlettroscoe requested review from rppawlo, eric-c-cyr and jmgate April 4, 2020 00:54

bartlettroscoe self-assigned this Apr 4, 2020

bartlettroscoe mentioned this pull request Apr 4, 2020

ATDM: Simplify finding and using TrilinosConfig.cmake #7125

Closed

rppawlo previously approved these changes Apr 6, 2020

View reviewed changes

eric-c-cyr previously approved these changes Apr 6, 2020

View reviewed changes

bartlettroscoe added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration labels Apr 8, 2020

ATDM: Add Trilinos_ROOT to load_matching_env.sh (trilinos#7125)

890cd44

bartlettroscoe dismissed stale reviews from eric-c-cyr and rppawlo via 890cd44 April 8, 2020 00:14

bartlettroscoe force-pushed the 7125-atdm-trilinos-root-install-dir branch from 56f56f7 to 890cd44 Compare April 8, 2020 00:14

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 8, 2020

rppawlo approved these changes Apr 8, 2020

View reviewed changes

trilinos-autotester merged commit 044ec98 into trilinos:develop Apr 8, 2020

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Apr 8, 2020

trilinos-autotester mentioned this pull request Apr 4, 2022

Kokkos + KokkosKernels Promotion To 3.6.0 #10253

Merged

ATDM: Simplify finding and using TrilinosConfig.cmake (#7125) #7126

ATDM: Simplify finding and using TrilinosConfig.cmake (#7125) #7126

Conversation

bartlettroscoe commented Apr 4, 2020

eric-c-cyr commented Apr 4, 2020 via email

trilinos-autotester commented Apr 5, 2020

trilinos-autotester commented Apr 5, 2020

trilinos-autotester commented Apr 5, 2020

trilinos-autotester commented Apr 8, 2020

trilinos-autotester commented Apr 8, 2020

bartlettroscoe commented Apr 8, 2020

trilinos-autotester commented Apr 8, 2020

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_python_2

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_python_3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Apr 8, 2020

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_python_2

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_python_3

Jenkins Parameters

trilinos-autotester commented Apr 8, 2020

trilinos-autotester commented Apr 8, 2020

trilinos-autotester commented Apr 8, 2020

trilinos-autotester commented Apr 8, 2020

trilinos-autotester commented Apr 8, 2020