Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amesos Package Warnings Fix #72

Closed
wants to merge 1 commit into from
Closed

Amesos Package Warnings Fix #72

wants to merge 1 commit into from
+49 −82

Conversation

bddavid
Copy link
Contributor

@bddavid bddavid commented Jan 7, 2016

Techx 0002 amesos package warnings fixes

Attention:

@jwillenbring
@trilinos/amesos

Signed-off-by: bddavid davidson@txcorp.com

@techxdave @bddavid
Amesos Package Warnings Fix
2f3ae17 
 - Removed unused timing code.
 - Removed unused variables.

Signed-off-by: bddavid <davidson@txcorp.com>
@jwillenbring
Copy link
Member

@srajama1

I want to make sure Siva is aware of this pull request.

@srajama1
Copy link
Contributor

Jim, How does one accept such pull requests ? Just follow the standard instructions above or do we have a separate process for Trilinos ?

@jwillenbring
Copy link
Member

Siva,

I recommend using the command line instructions option to pull the change into your local clone and then using your usual checkin testing process to test. For cosmetic changes (comments, etc), using the merge button may be appropriate.

@jwillenbring
Copy link
Member

@srajama1
Siva,

I realized that you may not have seen my reply above because I didn't "mention" you in my reply. If that is the case, here is my reply:

I recommend using the command line instructions option to pull the change into your local clone and then using your usual checkin testing process to test. For cosmetic changes (comments, etc), using the merge button may be appropriate.

@srajama1
Copy link
Contributor

srajama1 commented Feb 3, 2016

Thanks, Jim. I actually saw the reply as all participants get the e-mail. I am just slow, sorry ! There are lot of other high priority things going that we need to deliver. I know this could be something simple, let me try and find some time to integrate it.

@srajama1 srajama1 added the stage: in progress Work on the issue has started label Feb 9, 2016
@srajama1 srajama1 self-assigned this Feb 9, 2016
@srajama1 srajama1 closed this Feb 9, 2016
@srajama1 srajama1 removed the stage: in progress Work on the issue has started label Feb 9, 2016
@srajama1
Copy link
Contributor

srajama1 commented Feb 9, 2016

Commit 8c1c89.. fixes this

@bartlettroscoe
Copy link
Member

Can the associated Milestone "0002-Amesos-Package-Warnings-Fixes" be closed at this point? It would be nice to unclutter the list of Trilinos/Milestones epics if possible.

@bartlettroscoe
Copy link
Member

I am closing the associated milestone ""0002-Amesos-Package-Warnings-Fixes" to remove clutter.

@jgfouca jgfouca mentioned this pull request Jul 6, 2016
Merged
@kvmkrao kvmkrao mentioned this pull request Oct 11, 2017
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request Oct 2, 2021
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Oct 21, 2021
Closed
This was referenced Oct 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srajama1 srajama1

Labels
None yet
Projects
None yet
Milestone
0002-Amesos-Package-Warnings-Fixes
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bddavid @jwillenbring @srajama1 @bartlettroscoe @techxdave