Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Fix modify/sync issues in MultiVector and unit tests #8427

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Tpetra: Fix modify/sync issues in MultiVector and unit tests #8427

merged 5 commits into from
Dec 9, 2020

Conversation

tasmith4
Copy link
Contributor

@tasmith4 tasmith4 commented Dec 5, 2020

  • Change behavior of replaceLocalValue/sumIntoLocalValue to call modify_host and sync_host internally, which feels safer for users.
  • Remove a modify_device call inside multiVectorSingleColumnDot (since a dot product shouldn't change the values of the input vectors).
  • Also fixes some const inconsistencies and updates some debug ifdefs to use the Behavior class instead.

@trilinos/tpetra

Related Issues

Testing

MultiVector unit tests now passing in a non-UVM build on ascicgpu24.

@tasmith4 tasmith4 added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: Tpetra UVM removal labels Dec 5, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 2923
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 557
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 1053
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 8417
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 6152
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 1287
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 4053
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: tasmit/multivector-norm
  • SHA: 021e77a
  • Mode: TEST_REPO

Pull Request Author: tasmith4

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 2923
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 557
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 1053
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 8417
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 6152
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 1287
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 4053
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;UVM removal;pkg: Tpetra
PULLREQUESTNUM 8427
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tasmit/multivector-norm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 021e77a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8937932


CDash Test Results for PR# 8427.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

3 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@tasmith4 tasmith4 mentioned this pull request Dec 8, 2020
Closed
93 tasks
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

brian-kelley
brian-kelley approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@brian-kelley brian-kelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 543f0f8 into develop Dec 9, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 8427: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Dec 9, 2020
@tasmith4 tasmith4 deleted the tasmit/multivector-norm branch December 11, 2020 16:09
@tasmith4 tasmith4 mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-kelley brian-kelley brian-kelley approved these changes

@kddevin kddevin Awaiting requested review from kddevin

Assignees
No one assigned
Labels
pkg: Tpetra UVM removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tasmith4 @trilinos-autotester @brian-kelley