Changes to fix errors in LCM #9831
Merged
+48
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxmota
added
pkg: minitensor
AT: AUTOMERGE
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
Using Repos:
Pull Request Author: lxmota |
|
I just tested this and am getting the following compilation errors in Albany: Did you encounter this @lxmota ? |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Yes, LCM needs to be changed as well. I have the commits that fix this waiting in the wings for the Trilinos changes. Sorry, I just saw this.
Alejandro
From: "Irina K. Tezaur" ***@***.***>
Reply-To: trilinos/Trilinos ***@***.***>
Date: Tuesday, October 19, 2021 at 20:47
To: trilinos/Trilinos ***@***.***>
Cc: "Mota, Alejandro" ***@***.***>, Mention ***@***.***>
Subject: [EXTERNAL] Re: [trilinos/Trilinos] Changes to fix errors in LCM (PR #9831)
I just tested this and am getting the following compilation errors in Albany:
In file included from /home/ikalash/ACE/Albany-LCM-master/src/LCM/models/CrystalPlasticityModel.cpp:7:
/home/ikalash/ACE/Albany-LCM-master/src/LCM/models/CrystalPlasticityModel_Def.hpp: In instantiation of ‘void LCM::CrystalPlasticityKernel<EvalT, Traits>::operator()(int, int) const [with EvalT = PHAL::AlbanyTraits::Jacobian; Traits = PHAL::AlbanyTraits]’:
/home/ikalash/ACE/Albany-LCM-master/src/LCM/models/CrystalPlasticityModel.cpp:19:1: required from here
/home/ikalash/ACE/Albany-LCM-master/src/LCM/models/CrystalPlasticityModel_Def.hpp:615:41: error: no match for ‘operator=’ (operand types are ‘boost::tuples::detail::tie_mapper<minitensor::Tensor<double, 48>, minitensor::Tensor<double, 48>, minitensor::Tensor<double, 48>, void, void, void, void, void, void, void>::type’ {aka ‘boost::tuples::tuple<minitensor::Tensor<double, 48>&, minitensor::Tensor<double, 48>&, minitensor::Tensor<double, 48>&, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>’} and ‘std::tuple<minitensor::Tensor<double, 48>, minitensor::Tensor<double, 48>, minitensor::Tensor<double, 48> >’)
Did you encounter this @lxmota<https://github.com/lxmota> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#9831 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABWKJAP3OV4SZHJYLM6JOTDUHY3UTANCNFSM5GKQ7WTQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
ikalash
approved these changes
Oct 20, 2021
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ikalash ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 9831: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/discretizations
Motivation
Recent changes to MiniTensor led to compile errors in LCM
Stakeholder Feedback
Testing