Swap: Do not use bss memory in tezos swap library functions #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
force-pushed
the
palmer@functori@do-not-use-bss-memory-in-tezos-swap-library-functions
branch
from
a9bca26 to
5e85bde
Compare
emturner
reviewed
Jan 18, 2024
| @@ -46,6 +46,7 @@ void | |||
| swap_handle_check_address(check_address_parameters_t *params) | |||
| { | |||
| FUNC_ENTER(("params=%p", params)); | |||
| tz_exc _sw_ret_code = 0x0000; | |||
|
|
|||
| if (params->address_to_check == NULL) { | |||
| PRINTF("[ERROR] Address to check is null\n"); | |||
There was a problem hiding this comment.
change error to bail so you need only one flag.
ajinkyaraj-23
requested changes
Jan 18, 2024
spalmer25
force-pushed
the
palmer@functori@do-not-use-bss-memory-in-tezos-swap-library-functions
branch
from
7435a75 to
d40434e
Compare
ajinkyaraj-23
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding MACRO in
exception.hin order to return the error instead of putting it in the global variableglobal