-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix social login #291
Fix social login #291
Conversation
README.md
Outdated
|
||
Runs the electron app in the development mode. | ||
In order to get the dev tools work please make sure to set the `ENABLE_DEV_TOOLS` env variable to `true` | ||
In order to get the dev tools work please make sure to `devTools` to `true` in the `webPreferences` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set the devTools
:)
redirectToOpener: true, | ||
uxMode: "popup", | ||
network: toTorusNetwork(umamiNetwork), | ||
}); | ||
|
||
const authenticate = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the logic to prevent authenticating multiple times here as well. this way we don't have to rely on the button UI
if(loading) {
return;
}
6ac7d8f
to
318538a
Compare
|
||
const onSuccessfulSocialAuth = async (sk: string, email: string) => { | ||
const { pk, pkh } = await getPkAndPkhFromSk(sk); | ||
restoreSocial(pk, pkh, email); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we handle the case when this fails? e.g. ) the social account already exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, it throws, the same way as for other accounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
318538a
to
43b5aeb
Compare
Proposed changes
Task link
I fix a few issues:
electron:package:mac:debug
command. the&&
break things andNODE_ENV
is going to always be production when you build thanks to react create appENABLE_DEV_TOOLS=true open -a "Umami"
web3AuthClientId
was taken from Kukai since we are using their accountTypes of changes
Put an
x
in the boxes that applySteps to reproduce
baseUrl: "https://umamiwallet.com/auth/v2/"
, tobaseUrl: "https://umamiwallet-imdk0e12n-trili-tech.vercel.app/auth/v2/"
since it hasn't been deployedyarn electron:start
and sign up and/or sign a transactionsyarn build && yarn electron:package:mac:debug
then install the app from thedist
directory and repeat the steps aboveScreenshots
dev build:
ghost net operation sign
https://github.com/trilitech/umami-v2/assets/129749432/3529738c-2d61-46d5-a2af-c1301800bf4b
sign up
https://github.com/trilitech/umami-v2/assets/129749432/ebe746ba-490b-482f-9d90-01d9a9b082d5
ghost net sign up
https://github.com/trilitech/umami-v2/assets/129749432/c8b61412-7252-412a-be38-fadc037b0051
prod build:
sign up
https://github.com/trilitech/umami-v2/assets/129749432/50bc106f-adac-4be4-a192-43076f6a84d5
ghost net operation sign
https://github.com/trilitech/umami-v2/assets/129749432/0e967493-68d0-45d3-a4ee-2684977e7b24
account create toast
Checklist