client: impl IntoUrl for String for convenience
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easy to generate the base by using `.with_base(format!(...))`. `.with_base(&format!(...))` doesn't suffice in that case because Rust can't infer `&str` for the generic argument, so this would otherwise require `.with_base(format!(...).as_str())`.
joshtriplett
force-pushed
the
string-intourl
branch
from
da70956 to
9f24f92
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=======================================
Coverage 46.15% 46.15%
=======================================
Files 179 179
Lines 6977 6979 +2
=======================================
+ Hits 3220 3221 +1
- Misses 3757 3758 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl IntoUrl for Stringfor convenienceStringwithIntoUrl