Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with 6.0.2 SDK update #42

Closed
DavidWiseman opened this issue Feb 22, 2022 · 5 comments
Closed

Issue with 6.0.2 SDK update #42

DavidWiseman opened this issue Feb 22, 2022 · 5 comments
Assignees
@DavidWiseman
Labels
blocked blocked Completed DEV work completed. To be included in next release if issue is still open. Partial Fix Issue is mitigated by a partial fix

Comments

@DavidWiseman
Copy link
Collaborator

The issue is described here:
dotnet/winforms#6663

Since upgrading to the latest VS, the application builds with 6.0.2 and will fail to run on a machine without this version installed. The app fails silently and you have to discover the error using event viewer.
Ideally you would at least be prompted to upgrade to the new version.

As a workaround we can use 6.0.101 be specifying this in the Global.json and editing the workflows to use 6.0.101. At some point we might want to revert this change and upgrade to a newer version.
@DavidWiseman DavidWiseman self-assigned this Feb 22, 2022
@DavidWiseman DavidWiseman mentioned this issue Feb 22, 2022
Merged
@DavidWiseman DavidWiseman added blocked blocked Partial Fix Issue is mitigated by a partial fix labels Feb 22, 2022
@DavidWiseman DavidWiseman mentioned this issue Feb 25, 2022
Closed
DavidWiseman added a commit to DavidWiseman/dba-dash that referenced this issue Feb 25, 2022
@DavidWiseman
Fix CodeQL Security Scanning Workflow
c0dba9f 
Set runs on to windows-2019.  Set dotnet version
trimble-oss#44 trimble-oss#42
DavidWiseman added a commit to DavidWiseman/dba-dash that referenced this issue Feb 25, 2022
@DavidWiseman
Fix CodeQL Security Scanning Workflow
3e9c4ac 
Set runs on to windows-2019.  Set dotnet version
trimble-oss#44 trimble-oss#42
@DavidWiseman DavidWiseman mentioned this issue Feb 25, 2022
Merged
DavidWiseman added a commit that referenced this issue Feb 25, 2022
@DavidWiseman
Fix CodeQL Security Scanning Workflow
e01fc4a 
Set runs on to windows-2019.  Set dotnet version
#44 #42
@DavidWiseman DavidWiseman mentioned this issue Jun 8, 2022
Closed
@DavidWiseman
Copy link
Collaborator Author

Global.json has been removed #220. Project is still built with 6.0.101 on the github action for wider compatibility.

@DavidWiseman
Copy link
Collaborator Author

It looks like the backward compatibility might be broken now? The action is still targeting 6.0.101 - not sure when/how this got broken. It might be useful to investigate. Maybe just use the latest version now and ensure this is called out in the docs?

@DavidWiseman
Copy link
Collaborator Author

This was first broken in 2.22.9. Most likely it was introduced by this commit to bump the setup-dotnet action.

@DavidWiseman
Copy link
Collaborator Author

Changing actions/setup-dotnet@v3 to actions/setup-dotnet@v2 fixes the issue. It might be time to move to the new version though and run a check in the upgrade script.

DavidWiseman added a commit to DavidWiseman/dba-dash that referenced this issue Oct 21, 2022
@DavidWiseman
Update script to check .net version
056fe34 
Versions older than 6.0.2 are not supported now (App will fail to run).  Prompt user to upgrade.
trimble-oss#42
@DavidWiseman DavidWiseman mentioned this issue Oct 21, 2022
Merged
DavidWiseman added a commit that referenced this issue Oct 21, 2022
@DavidWiseman
Update script to check .net version
ba1b09b 
Versions older than 6.0.2 are not supported now (App will fail to run).  Prompt user to upgrade.
#42
DavidWiseman added a commit to DavidWiseman/dba-dash that referenced this issue Nov 7, 2022
@DavidWiseman
Update .NET SDK in GitHub Action
f1548b2 
Build with latest version of SDK.  Previously this was set to 6.0.101 due to breaking changes. Backward compatibility was broken with update to actions/setup-dotnet@v3.  Issue is now documented and latest version is preferred.
 trimble-oss#42
@DavidWiseman DavidWiseman mentioned this issue Nov 7, 2022
Merged
DavidWiseman added a commit that referenced this issue Nov 7, 2022
@DavidWiseman
Update .NET SDK in GitHub Action
c219eff 
Build with latest version of SDK.  Previously this was set to 6.0.101 due to breaking changes. Backward compatibility was broken with update to actions/setup-dotnet@v3.  Issue is now documented and latest version is preferred.
 #42
@DavidWiseman DavidWiseman added the Completed DEV work completed. To be included in next release if issue is still open. label Nov 7, 2022
@DavidWiseman
Copy link
Collaborator Author

GH Actions have now been updated to use the latest version. Backward compatibility issue is documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidWiseman DavidWiseman

Labels
blocked blocked Completed DEV work completed. To be included in next release if issue is still open. Partial Fix Issue is mitigated by a partial fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidWiseman