Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

disabled tabs again #1392

Closed
rapropos opened this issue Oct 1, 2018 · 5 comments
Closed

disabled tabs again #1392

rapropos opened this issue Oct 1, 2018 · 5 comments
Labels
enhancement

Comments

@rapropos
Copy link
Contributor

rapropos commented Oct 1, 2018

What Angular MDC version are you using?

0.38+

App code dependent on the ability to disable tabs that was graciously provided in #147 now breaks in 0.38+ as the disabled attribute is not available on the new tab bar implementation. Can this feature please be restored somehow?
@trimox
Copy link
Owner

trimox commented Oct 1, 2018

Can do. Thanks for reminding me.

@trimox
Copy link
Owner

trimox commented Oct 2, 2018

PR incoming
image

trimox added a commit that referenced this issue Oct 2, 2018
@trimox
feat(tab): Add disabled property
8aa42af 
Closes #1392
@trimox trimox mentioned this issue Oct 2, 2018
Merged
@trimox
Copy link
Owner

trimox commented Oct 2, 2018

Will be releasing v0.40.1 today.

trimox added a commit that referenced this issue Oct 2, 2018
@trimox
feat(tab): Add disabled property (#1395)
dd31b85 
Closes #1392
@trimox
Copy link
Owner

trimox commented Oct 2, 2018

Just fyi, I may need to submit another PR for disabling navigation via keyboard.

@rapropos
Copy link
Contributor Author

rapropos commented Oct 2, 2018

Thank you so much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rapropos @trimox