Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

feat(menu): Support keeping surface open after selection #2003

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

trimox
Copy link
Owner

@trimox trimox commented Sep 10, 2019

Whether the menu surface should close after item selection. Default is true

  • Adds closeSurfaceOnSelection: boolean
  • Update documentation
  • Update test coverage

closes #2001 ref #1997

@trimox trimox added this to the v3.2.1 milestone Sep 10, 2019
@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #2003 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
+ Coverage   90.27%   90.33%   +0.06%     
==========================================
  Files          97       97              
  Lines        4296     4302       +6     
  Branches      576      578       +2     
==========================================
+ Hits         3878     3886       +8     
+ Misses        221      219       -2     
  Partials      197      197
Impacted Files Coverage Δ
packages/menu/menu.ts 71.79% <100%> (+2.35%) ⬆️
packages/dialog/dialog.component.ts 84.61% <0%> (+1.28%) ⬆️
packages/ripple/ripple.service.ts 85.41% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef0639...33fe015. Read the comment docs.

@trimox trimox merged commit 5408da3 into master Sep 10, 2019
@trimox trimox deleted the feat/add-close-surface-on-selection branch September 10, 2019 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support preventing selection from closing menu surface
1 participant