Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

feat(menu): Support default focus state #2004

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Conversation

trimox
Copy link
Owner

@trimox trimox commented Sep 11, 2019

  • Adds defaultFocusState: 'none' | 'list' | 'firstItem' | 'lastItem' for MdcMenu
  • Minor code refactoring of MdcMenuSurfaceBase
  • Update documentation
  • Include unit test

closes #1998

@trimox trimox added this to the v3.2.1 milestone Sep 11, 2019
@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #2004 into master will increase coverage by 0.31%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2004      +/-   ##
==========================================
+ Coverage   90.33%   90.64%   +0.31%     
==========================================
  Files          97       97              
  Lines        4302     4307       +5     
  Branches      578      579       +1     
==========================================
+ Hits         3886     3904      +18     
+ Misses        219      206      -13     
  Partials      197      197
Impacted Files Coverage Δ
packages/menu/menu.ts 87.95% <88.88%> (+16.15%) ⬆️
packages/list/list.ts 84.86% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5408da3...7d0c2d3. Read the comment docs.

@trimox trimox marked this pull request as ready for review September 11, 2019 20:52
@trimox trimox merged commit 926c076 into master Sep 13, 2019
@trimox trimox deleted the feat/menu-focus-state branch September 13, 2019 00:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu keyboard focus state
1 participant