Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

feat(theme): Allow overriding of text themes #299

Closed
wants to merge 2 commits into from

Conversation

gline9
Copy link

@gline9 gline9 commented Oct 21, 2017

When theme colors are very close to the border of light vs dark theme, the chosen text color can be different that what you want. Currently there is no way to change which text theme was chosen for a particular color. This can be accomplished by adding the !default tag to the chosen theme and allowing the variable to be overridden similarly to how the theme colors can be.

@codecov
Copy link

codecov bot commented Oct 21, 2017

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          91       91           
  Lines        4653     4653           
  Branches      901      901           
=======================================
  Hits         4241     4241           
  Misses        412      412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914cfda...7dd62fe. Read the comment docs.

@trimox trimox self-assigned this Oct 23, 2017
@trimox
Copy link
Owner

trimox commented Oct 24, 2017

Hey @gline9 Thanks for your PR! Developers would appreciate the flexibility to customize the tone colors.

The tone variables were implemented to compute a minimum contrast ratio to ensure color blind user accessibility. I also understand the MDC team has no plans to allow developers to alter these variables.

Long and short, our current process to sync upstream Sass changes is to re-import all the Sass from material-components-web into src/theme/material-components-web. Re-importing means the changes in _variables.scss would be lost.

Currently we extend the Sass of material-components-web using src/theme/material.scss and src/theme/extend. However; this approach would not work either.

I'm open to feedback regarding re-importing of upstream Sass files! 😄
Thanks again,
-trimox

@trimox
Copy link
Owner

trimox commented Oct 29, 2017

Closing. PR exists upstream: material-components/material-components-web#1481

@trimox trimox closed this Oct 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants