Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

feat(select): Replace menu with native html select #834

Merged
merged 8 commits into from
Apr 8, 2018

Conversation

trimox
Copy link
Owner

@trimox trimox commented Apr 4, 2018

Change as per material-components-web v0.34.1.
reference: material-components/material-components-web#2462

BREAKING CHANGE:

  • The template and adapter APIs have changed to take advantage of the native select element; see the MDC Select README for more information.
  • Removed mdc-select-item component. Replace with HTML5's native option element.

@trimox trimox added enhancement do-not-merge new-mdc-feature Feature incorporated from material-components-web labels Apr 4, 2018
@trimox trimox added this to the v0.34.1 milestone Apr 4, 2018
@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2283da3). Click here to learn what that means.
The diff coverage is 95.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #834   +/-   ##
=========================================
  Coverage          ?   92.13%           
=========================================
  Files             ?      166           
  Lines             ?     6506           
  Branches          ?      983           
=========================================
  Hits              ?     5994           
  Misses            ?      512           
  Partials          ?        0
Impacted Files Coverage Δ
src/lib/slider/slider-module.ts 100% <ø> (ø)
src/lib/select/public-api.ts 100% <100%> (ø)
src/lib/select/select-module.ts 100% <100%> (ø)
src/lib/select/select-label.ts 100% <100%> (ø)
src/lib/select/select-bottom-line.ts 88.23% <87.87%> (ø)
src/lib/select/select.ts 94.14% <97.53%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2283da3...0cb3c81. Read the comment docs.

@trimox trimox merged commit 61a3171 into master Apr 8, 2018
@trimox trimox deleted the feat/select-native branch April 8, 2018 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement new-mdc-feature Feature incorporated from material-components-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant