Temporary fix for https://github.com/jetty/jetty.project/issues/11841 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randgalt
force-pushed
the
jordanz/temp-fix-for-jetty
branch
from
576f911 to
e7afebb
Compare
mosiac1
reviewed
Jul 24, 2024
| @@ -0,0 +1,556 @@ | |||
| // | |||
There was a problem hiding this comment.
This file seems to be from jetty/jetty.project#11891 with only formatting changes; should we add a comment about this?
There was a problem hiding this comment.
There is one change and I added a comment. See here: https://github.com/trinodb/aws-proxy/pull/115/files#diff-e49a593f01de37b2d08fffd09c2c9fe1755f45206d789e654408a04ccdfed44aR217
Randgalt
force-pushed
the
jordanz/temp-fix-for-jetty
branch
from
e7afebb to
0eb32f9
Compare
|
Damn - we just got |
Randgalt
force-pushed
the
jordanz/temp-fix-for-jetty
branch
2 times, most recently
from
f44bd33 to
388bdff
Compare
jetty/jetty.project#11841 has an NPE when using 100-Continue. This hack is a workaround. - Create a new module that generates a JAR that will sort first in the classpath - Put a hacked version of Jetty's `HttpSender` in this module that has a fix - The Java classloader will load this version of the class first, thus working around the problem This hack should be removed as soon as possible
Randgalt
force-pushed
the
jordanz/temp-fix-for-jetty
branch
from
388bdff to
7288166
Compare
Merged
Randgalt
force-pushed
the
jordanz/temp-fix-for-jetty
branch
from
7288166 to
61e7f18
Compare
mosiac1
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jetty/jetty.project#11841 has an NPE when using 100-Continue. This hack is a workaround.
HttpSenderin this module that has a fixThis hack should be removed as soon as possible