Skip to content

Commit

Permalink
Support pod.spec.containers.securityContext specification
Browse files Browse the repository at this point in the history
This PR attempts to close #116

Following the valeriano-manassero's implementation,
https://github.com/valeriano-manassero/helm-charts/blob/6382a14272927a908bc006d0f1370ba9dffc821f/valeriano-manassero/trino/values.yaml#L467-L471

let me Support `pod.spec.containers.securityContext`  specification
  • Loading branch information
LittleWat committed Mar 12, 2024
1 parent 6b68924 commit dd5e3ed
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions charts/trino/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ The following table lists the configurable parameters of the Trino chart and the
| `coordinator.annotations` | | `{}` |
| `coordinator.labels` | | `{}` |
| `coordinator.secretMounts` | | `[]` |
| `coordinator.containerSecurityContext` | | `{}` |
| `worker.jvm.maxHeapSize` | | `"8G"` |
| `worker.jvm.gcMethod.type` | | `"UseG1GC"` |
| `worker.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` |
Expand All @@ -96,6 +97,7 @@ The following table lists the configurable parameters of the Trino chart and the
| `worker.annotations` | | `{}` |
| `worker.labels` | | `{}` |
| `worker.secretMounts` | | `[]` |
| `worker.containerSecurityContext` | | `{}` |
| `kafka.mountPath` | | `"/etc/trino/schemas"` |
| `kafka.tableDescriptions` | | `{}` |
| `commonLabels` | Labels that get applied to every resource's metadata | `{}` |
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/deployment-coordinator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ spec:
- name: {{ .Chart.Name }}-coordinator
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
securityContext:
{{- toYaml .Values.containerSecurityContext | nindent 12 }}
env:
{{- toYaml .Values.env | nindent 12 }}
envFrom:
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/deployment-worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ spec:
- name: {{ .Chart.Name }}-worker
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
securityContext:
{{- toYaml .Values.containerSecurityContext | nindent 12 }}
env:
{{- toYaml .Values.env | nindent 12 }}
envFrom:
Expand Down
7 changes: 7 additions & 0 deletions charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,13 @@ securityContext:
runAsUser: 1000
runAsGroup: 1000

# -- SecurityContext configuration for containers
containerSecurityContext:
allowPrivilegeEscalation: false # Controls whether a process can gain more privileges than its parent process.

Check failure on line 223 in charts/trino/values.yaml

View workflow job for this annotation

GitHub Actions / lint

[trailing-spaces] trailing spaces
capabilities:

Check failure on line 224 in charts/trino/values.yaml

View workflow job for this annotation

GitHub Actions / lint

[trailing-spaces] trailing spaces
drop: # Kernel capabilities that will be dropped from a pod
- ALL

Check failure on line 226 in charts/trino/values.yaml

View workflow job for this annotation

GitHub Actions / lint

[trailing-spaces] trailing spaces

shareProcessNamespace:
coordinator: false
worker: false
Expand Down

0 comments on commit dd5e3ed

Please sign in to comment.