Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled overrides for worker and coordinator configmap resources #173

Merged
merged 1 commit into from
May 31, 2024
Merged

Enabled overrides for worker and coordinator configmap resources #173

merged 1 commit into from
May 31, 2024

Conversation

nineinchnick
Copy link
Member

Replaces #163 and #170

Closes #159

@cla-bot cla-bot
Copy link

cla-bot bot commented May 30, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick nineinchnick mentioned this pull request May 30, 2024
Closed
@cla-bot cla-bot
Copy link

cla-bot bot commented May 30, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot cla-bot bot added the cla-signed label May 30, 2024
@nineinchnick
Copy link
Member Author

I rebased this on top of #172. This is now so different from #163, that I've reset the commit author to myself.

@nineinchnick nineinchnick merged commit e033dcd into trinodb:main May 31, 2024
9 checks passed
@nineinchnick nineinchnick deleted the name-overrides branch May 31, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@mosabua mosabua Awaiting requested review from mosabua

@hashhar hashhar Awaiting requested review from hashhar

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot deploy multiple trino clusters in the same k8s namespace
2 participants
@nineinchnick @wendigo