Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set resources for the JMX Exporter container #207

Merged

Conversation

rotem-ad
Copy link
Member

Allows to set resources for the JMX Exporter container.
Resolves #202 for K8s clusters with strict resource quota policies.

Copy link

cla-bot bot commented Aug 15, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Aug 24, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Aug 24, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick
Copy link
Member

@rotem-ad can you rebase?

@cla-bot cla-bot bot added the cla-signed label Sep 9, 2024
@nineinchnick
Copy link
Member

@rotem-ad something went wrong with the rebase, the diff shows too many changes. Can you try again? If you're rebasing on the main branch in your repository, try updating it first, to match the remote repository.

@rotem-ad rotem-ad force-pushed the feature/set-resources-for-jmx-exporter branch from 04c48d0 to 8da38d9 Compare September 9, 2024 08:48
@rotem-ad
Copy link
Member Author

rotem-ad commented Sep 9, 2024

@nineinchnick done

@nineinchnick nineinchnick added the enhancement New feature or request label Sep 9, 2024
@nineinchnick
Copy link
Member

One last nitpick - please remove Feature: from the commit message. It'll get added in release notes, and will be redundant with the section title.

@rotem-ad rotem-ad force-pushed the feature/set-resources-for-jmx-exporter branch from 8da38d9 to 838777f Compare September 9, 2024 10:18
@rotem-ad
Copy link
Member Author

rotem-ad commented Sep 9, 2024

@nineinchnick done

@nineinchnick nineinchnick changed the title Feature: allows to set resources for the JMX Exporter container. Resolves #202 Allow to set resources for the JMX Exporter container Sep 9, 2024
@nineinchnick nineinchnick merged commit d52941b into trinodb:main Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Unable to Set Resources for JMX Exporter in Trino Helm Chart
2 participants