Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom password auth properties file #218

Merged

Conversation

yardenc2003
Copy link
Contributor

@yardenc2003 yardenc2003 commented Sep 3, 2024

As for now, one you've set your auth type to "PASSWORD" via Values.server.config.authenticationType, you are forced to use a specific conf file set for password file auth.

This implementation restricts auth configurations in the following ways:

  1. It restricts the usage of configurations specific to that auth implementation (e.g., we cannot configure file.auth-token-cache.max-size).
  2. Even worse, it does not allow configuring LDAP properties, which should also be enabled by the "PASSWORD" auth type.

This PR suggests a small fix to address these scenarios.

Copy link

cla-bot bot commented Sep 3, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@yardenc2003
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 7, 2024
Copy link

cla-bot bot commented Sep 7, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick nineinchnick added the enhancement New feature or request label Sep 8, 2024
@nineinchnick nineinchnick merged commit 349eca2 into trinodb:main Sep 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants