Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added annotation for automatically roll deployments #51

Closed

Conversation

ashishjullia
Copy link

No description provided.

@cla-bot
Copy link

cla-bot bot commented Aug 11, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ashishjullia
Copy link
Author

It replicates this.

Problem was:
Every time a new catalog was added/removed, even after helm upgrade even though the configMap updates the content inside pod/container/volume, trino coordinator doesn't loads/reads it and deployment won't get updated which results in no new pod creation.

Solution is:
Adding this annotation solves that + if more configMaps needs to be targeted, they can be added under this annotation.

@nineinchnick
Copy link
Member

Duplicated by #127, I'll close this for now, but feel free to reopen after rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants