Allow annotations and labels for the worker and coordinator pods #75
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Update: Submitted CLA today. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Can this be merged? I was just about to open a PR for the same feature. |
|
Please can someone take a look at getting this approved? The same would also be very useful for labels |
|
@connorlwilkes Can add labels shortly. |
mjpsyapse
changed the title
|
Thank you @mjpsyapse |
|
@radek-starburst any chance getting this reviewed please? |
|
Hey can this please be added I was about to raise a PR regarding the same |
|
Hi, can this please be merged? |
@radek-starburst Coming up! |
Update charts/trino/README.md Add labels for worker and coordinator Fix spacing
There was a problem hiding this comment.
looks good to me. I have no permission to merge it cc @losipiuk
Annotations are useful for integrating with a service mesh and/or cloud providers.
Also see #54. I noticed the CLA wasn't signed yet for that PR. I can port those changes here if needed.