Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename QueryIdCachingProxyHandler class #480

Open
ebyhr opened this issue Sep 25, 2024 · 1 comment · May be fixed by #504
Open

Rename QueryIdCachingProxyHandler class #480

ebyhr opened this issue Sep 25, 2024 · 1 comment · May be fixed by #504
Labels
good first issue Good for newcomers

Comments

@ebyhr
Copy link
Member

ebyhr commented Sep 25, 2024 •
edited
Loading

The class name seems wrong. We should rename to TrinoHttpUtils or something (or separate into some classes).
@ebyhr ebyhr added the good first issue Good for newcomers label Sep 25, 2024
@RiyaJohn
Copy link

RiyaJohn commented Oct 2, 2024

@ebyhr Shall I move it to a Constants.java file created under util/ that can be used across the project?

@RiyaJohn RiyaJohn linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename QueryIdCachingProxyHandler to Constants.java RiyaJohn/trino-gateway
2 participants
@ebyhr @RiyaJohn