Rename QueryIdCachingProxyHandler to Constants.java

[RiyaJohn]

Description

Fixes #480

Release notes

• (x) This is not user-visible or is docs only, and no release notes are required.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Riya John.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[willmostly]

Thanks for the submission @RiyaJohn, this looks like it can be merged once cla-bot is happy. My only question is if we want to add a utils subpackage or put this class in an existing one. @oneonestar , @Chaho12 , @vishalya any opinion?

[ebyhr]

Put { on a separate line and you could add final.

[ebyhr]

The name is too general. Please rename to TrinoHttpUtil or something.

[Chaho12]

I like the part where it has Trino because this class is meant for Trino http spec.

[ebyhr]

Please don't remove license header.

[ebyhr]

Please don't remove a constructor.

[RiyaJohn]

you mean we have to retain QueryIdCachingProxyHandler class file with this constructor?

[ebyhr]

No, I meant keeping a private constructor.

[Chaho12]

LGTM if we rename the class name.
I think we should have it as a separate class because this is Trino http spec, not gateway.

[Chaho12]

I like the part where it has Trino because this class is meant for Trino http spec.

[mosabua]

Having a generic util package and a generic Constants class is an antipattern .. it will just end up as a big undefined class with no focus and spread into the codebase all over as a dependency. Please keep it focussed like in the original issues from @ebyhr

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Riya John.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Riya John.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[RiyaJohn]

@ebyhr I think I have addressed the review comments, please take a look at it. And I need help with this cla-signing. I have an email configured and I can see it in the git config, so not sure what is missing