Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace blackListHeaders with excludeHeaders #470

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Replace blackListHeaders with excludeHeaders #470

merged 1 commit into from
Sep 24, 2024

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Sep 13, 2024 •
edited
Loading

Description

Use excludeHeaders instead as blacklist isn't recommended in software projects.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Replace `blackListHeaders` with `excludeHeaders` in the routing rule configuration

@cla-bot cla-bot bot added the cla-signed label Sep 13, 2024
@Chaho12 Chaho12 changed the title Use blacklistHeaders instead of blackListHeaders Use excludeHeaderList instead of blackListHeaders Sep 13, 2024
@mosabua
Copy link
Member

mosabua commented Sep 13, 2024

Agreed .. this is a good change @Chaho12

@ebyhr
Copy link
Member

ebyhr commented Sep 15, 2024

  • Use excludeHeaders instead of blackListHeaders

Thanks for writing a release note entry. I would recommend mentioning where the excludeHeaders is used, e.g. "Use Replace blackListHeaders with excludeHeaders in the routing rule configuration"

ebyhr
ebyhr approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left come comments which can be addressed in a follow-up PR.

@mosabua
Copy link
Member

mosabua commented Sep 18, 2024

please rebase and address the few small comments @Chaho12 .. then we can merge

@ebyhr
Copy link
Member

ebyhr commented Sep 20, 2024 •
edited
Loading

Use excludeHeaderList instead of blackListHeaders #470

Please update the PR title.

@Chaho12 Chaho12 changed the title Use excludeHeaderList instead of blackListHeaders Replace blackListHeaders with excludeHeaders Sep 22, 2024
@ebyhr ebyhr merged commit 0f687f4 into trinodb:main Sep 24, 2024
3 checks passed
@github-actions github-actions bot added this to the 12 milestone Sep 24, 2024
@Chaho12 Chaho12 deleted the feature/fix-spelling branch September 24, 2024 07:20
@mosabua mosabua mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua left review comments

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
12
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaho12 @mosabua @ebyhr