Update docs to add encoding header to be excluded #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
reviewed
Sep 27, 2024
Chaho12
force-pushed
the
feature/add-default-header
branch
from
1b0cb91
to
46cde22
Compare
Chaho12
force-pushed
the
feature/add-default-header
branch
from
46cde22
to
b4356ef
Compare
|
@mosabua Gentle reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When decoding JSON response using
io.airlift.http.client#createJsonResponseHandlerat external routing group selector code,JSON response could be compressed in GZIP (or whatever format) depending on the network configuration.
This is not expecected behaviour by Airlift as it read bytes.
So, I suggest adding
'Accept-Encoding'to docs so that user can know they might need to exclude it when making API request to server.Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
*