Fix SQLAlchemy URL parsing

trinodb · May 30, 2023 · 985c999 · 985c999
1 parent df0cc3e
commit 985c999
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/tests/unit/sqlalchemy/test_dialect.py b/tests/unit/sqlalchemy/test_dialect.py
@@ -199,6 +199,28 @@ def setup_method(self):
  source="trino-sqlalchemy",
  ),
  ),
+ (
+ make_url(trino_url(
+ user="user",
+ host="localhost",
+ client_tags=["1", "sql"],
+ legacy_prepared_statements=False,
+ )),
+ 'trino://user@localhost:8080/'
+ '?client_tags=%5B%221%22%2C+%22sql%22%5D'
+ '&legacy_prepared_statements=false'
+ '&source=trino-sqlalchemy',
+ list(),
+ dict(
+ host="localhost",
+ port=8080,
+ catalog="system",
+ user="user",
+ source="trino-sqlalchemy",
+ client_tags=["1", "sql"],
+ legacy_prepared_statements=False,
+ ),
+ ),
  ],
  )
  def test_create_connect_args(

diff --git a/trino/sqlalchemy/dialect.py b/trino/sqlalchemy/dialect.py
@@ -129,7 +129,7 @@ def create_connect_args(self, url: URL) -> Tuple[Sequence[Any], Mapping[str, Any
  kwargs["legacy_primitive_types"] = json.loads(unquote_plus(url.query["legacy_primitive_types"]))
 
  if "legacy_prepared_statements" in url.query:
- kwargs["legacy_prepared_statements"] = unquote_plus(url.query["legacy_prepared_statements"])
+ kwargs["legacy_prepared_statements"] = json.loads(unquote_plus(url.query["legacy_prepared_statements"]))
 
  if "verify" in url.query:
  kwargs["verify"] = json.loads(unquote_plus(url.query["verify"]))