Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of legacy_prepared_statements parameter #380

Merged
merged 2 commits into from
May 30, 2023

Conversation

aalbu
Copy link
Member

@aalbu aalbu commented May 26, 2023

Description

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 26, 2023
@aalbu aalbu changed the title Fix caching for parameterized statement execution mode Fix handling of legacy_prepared_statements parameter May 26, 2023
@aalbu aalbu force-pushed the aa/execute-immediate-check branch from e34b2dd to 985c999 Compare May 30, 2023 03:58
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

tests/integration/test_dbapi_integration.py Show resolved Hide resolved
tests/integration/test_dbapi_integration.py Show resolved Hide resolved
tests/integration/test_dbapi_integration.py Outdated Show resolved Hide resolved
@aalbu aalbu force-pushed the aa/execute-immediate-check branch from 985c999 to 6058e96 Compare May 30, 2023 11:35
@aalbu aalbu requested a review from hashhar May 30, 2023 11:44
@hashhar hashhar merged commit adb4794 into trinodb:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants