Fix 'Engine' object has no attribute 'connection' #255
Conversation
|
This issue seems to occur only in combination with sqlalchemy 1.3. So we better first merge #254 |
| @@ -11,6 +11,7 @@ | |||
| # limitations under the License | |||
| import pytest | |||
| import sqlalchemy as sqla | |||
| from sqlalchemy import inspect | |||
There was a problem hiding this comment.
It's already imported in one line above.
| metadata.create_all(engine) | ||
| insp = inspect(engine) | ||
| actual = insp.get_table_comment(table_name='table_with_id', schema="test") | ||
| assert actual['text'] is None |
There was a problem hiding this comment.
can we have a test for some actual comment?
There was a problem hiding this comment.
It would be great, but it seems to not work to add a comment through sqlalchemy. Let's create a bug for that.
There was a problem hiding this comment.
create an issue + add a TODO. Goal is to make sure if someone other than you works on that issue then they can easily find places in code which need updating otherwise they may end up adding duplicated tests.
mdesmet
force-pushed
the
bug/sqlalchemy-connection
branch
from
2158eb4
to
5b3290a
Compare
| metadata.create_all(engine) | ||
| insp = inspect(engine) | ||
| actual = insp.get_table_comment(table_name='table_with_id', schema="test") | ||
| assert actual['text'] is None |
There was a problem hiding this comment.
create an issue + add a TODO. Goal is to make sure if someone other than you works on that issue then they can easily find places in code which need updating otherwise they may end up adding duplicated tests.
mdesmet
force-pushed
the
bug/sqlalchemy-connection
branch
from
5b3290a
to
fe85b7a
Compare
Description
Fixes #253
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: