Support execute chaining #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
Jan 10, 2023
| self._iterator = iter(result) | ||
| return result | ||
| self._iterator = iter(self._query.execute()) | ||
| return self | ||
|
|
||
| def executemany(self, operation, seq_of_params): |
There was a problem hiding this comment.
For consistency do we also want it for executemany?
There was a problem hiding this comment.
added for consistency
damian3031
force-pushed
the
support-execute-chaining
branch
from
3555cf5
to
afc73fd
Compare
mdesmet
approved these changes
Jan 10, 2023
hashhar
approved these changes
Jan 10, 2023
This was referenced Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #279
Now it is possible to chain fetch operations. Added test for it.