-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visit_try_cast to sqlalchemy compiler #474
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
I just emailed the signed CLA. |
Thanks for your contribution! Could you please add a test for it? |
Sure! I should add one here, right? |
Yes, correct. |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
I have added a unit test. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@dwolfeu Please make test conditional to run only with SQLAlchemy 2.x since it seems 1.x doesn't have |
9afd094
to
39eb496
Compare
@hashhar Thanks for reviewing this PR. I have added an exception to the unit test. Three tests still fail, but that seems to be unrelated to my changes. |
thanks, those are indeed unrelated. @hovaesco can you help take a look at the The PyPy failures we can tackle separately since it's about Kerberos + PyPy incompat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've squashed (logically a single change) and rebased on master (to fix CI).
Will merge, sorry for the slow work.
Fixed some linter errors. |
Not at all! Thank you for the collaboration. :) |
Description
I have added a
visit_try_cast()
method totrino.sqlalchemy.compiler.TrinoSQLCompiler
. This fixes issue 473.Non-technical explanation
This allows Trino's
try_cast()
to be used in SQLAlchemy.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: