-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit configuration #500
Conversation
rev: "5.13.2" | ||
hooks: | ||
- id: isort | ||
args: [ "--profile", "black"] | ||
- id: "isort" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might become a problem in the future since pre-commit clean && pre-commit run --all
gives a warning:
[INFO] Initializing environment for https://github.com/PyCQA/isort.
[WARNING] repo `https://github.com/PyCQA/isort` uses deprecated stage names (commit, merge-commit, push) which will be removed in a future version. Hint: often `pre-commit autoupdate --repo https://github.com/PyCQA/isort` will fix this. if it does not -- consider reporting an issue to that repo.
Unfortunately the project haven’t seen updates for almost a year. There is an alternative though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for bringing this up. Would you like to submit follow-up PR (or separate commit here) to migrate from isort to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, I’ll check it out as a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, errors are for sure easier to make out now
Thank you.
@hashhar, can I ask you to merge this PR? I don’t think I have access to merging, at least I don’t see the button on the GitHub UI. |
Description
Updates the
pre-commit
configuration to have newest repo versions and gives names to individual hooks. Looks like this:Release notes
This is not user-visible or docs only and no release notes are required.