Avoid unnecessary I/O when skipping in S3InputStream with unknown length

trinodb · Sep 19, 2023 · 1668ef3 · 1668ef3
1 parent f034b22
commit 1668ef3
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3InputStream.java b/lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3InputStream.java
@@ -139,14 +139,8 @@ public void skipNBytes(long n)
             return;
         }
 
-        if (length == null) {
-            seekStream();
-            super.skipNBytes(n);
-            return;
-        }
-
         long position = nextReadPosition + n;
-        if ((position < 0) || (position > length)) {
+        if ((position < 0) || (length != null && position > length)) {
             throw new EOFException("Unable to skip %s bytes (position=%s, fileSize=%s): %s".formatted(n, nextReadPosition, length, location));
         }
         nextReadPosition = position;