Avoid quadratic traversal when many columns accessible

When `hide-inaccessible-columns` is enabled and table has N accessible columns, `filterInaccessibleFields` would have `O(N²)` running time.
trinodb · Sep 19, 2023 · 9acc35e · 9acc35e
1 parent 76d9b01
commit 9acc35e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java b/core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
@@ -4355,7 +4355,7 @@ private List<Field> filterInaccessibleFields(List<Field> fields)
                 return fields;
             }
 
-            List<Field> accessibleFields = new ArrayList<>();
+            ImmutableSet.Builder<Field> accessibleFields = ImmutableSet.builder();
 
             //collect fields by table
             ListMultimap<QualifiedObjectName, Field> tableFieldsMap = ArrayListMultimap.create();
@@ -4383,7 +4383,7 @@ private List<Field> filterInaccessibleFields(List<Field> fields)
             });
 
             return fields.stream()
-                    .filter(field -> accessibleFields.contains(field))
+                    .filter(accessibleFields.build()::contains)
                     .collect(toImmutableList());
         }