Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading of redis table description files by schedule #12123

Merged
merged 2 commits into from
May 11, 2022
Merged

Support loading of redis table description files by schedule #12123

merged 2 commits into from
May 11, 2022

Conversation

polaris6
Copy link
Member

@polaris6 polaris6 commented Apr 25, 2022 •
edited
Loading

Description

Support dynamic loading of redis table description files.

Related issues, pull requests, and links

Fixes #12240

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

# Redis
* Support dynamic loading of redis table description files. ({issue}`12240`)

@cla-bot cla-bot bot added the cla-signed label Apr 25, 2022
@github-actions github-actions bot added the docs label Apr 25, 2022
@polaris6 polaris6 requested a review from findepi April 25, 2022 12:57
@findepi findepi requested review from wendigo and removed request for findepi April 25, 2022 14:34
@polaris6 polaris6 force-pushed the dynamic-load-redis-schema branch 4 times, most recently from 60cd24e to a42dad0 Compare April 26, 2022 06:27
@polaris6
Copy link
Member Author

polaris6 commented Apr 26, 2022 •
edited
Loading

hi @ebyhr, I fixed the conflict and resubmitted, could you please help me to merge this pr? Thank you very much!

@polaris6 polaris6 requested review from ebyhr April 28, 2022 02:10
@polaris6 polaris6 force-pushed the dynamic-load-redis-schema branch from a42dad0 to 5033f33 Compare April 28, 2022 14:16
@polaris6
Copy link
Member Author

polaris6 commented May 3, 2022

hi @ebyhr, could you please help me to merge this pr? Thank you very much!

@polaris6
Copy link
Member Author

polaris6 commented May 9, 2022

Hi @ebyhr, I'm sorry to bother you, do I need to do something to perfect this pr?

@polaris6 polaris6 force-pushed the dynamic-load-redis-schema branch 2 times, most recently from 5033f33 to e05813c Compare May 9, 2022 09:56
@polaris6 polaris6 force-pushed the dynamic-load-redis-schema branch from e05813c to 75ea4b1 Compare May 10, 2022 06:42
ebyhr
ebyhr approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding commit message of "Support dynamic loading of redis table description files"

"dynamic loading" sounds detecting the changes without waiting time. Could you reword to "Support loading Redis table description files by schedule" or something?

@polaris6 polaris6 force-pushed the dynamic-load-redis-schema branch 3 times, most recently from a55a76b to 82d35f9 Compare May 10, 2022 10:15
@polaris6 polaris6 force-pushed the dynamic-load-redis-schema branch from 82d35f9 to 970202d Compare May 10, 2022 10:22
@ebyhr ebyhr changed the title Support dynamic loading of redis table description files Support loading of redis table description files by schedule May 11, 2022
@ebyhr ebyhr merged commit 6eb4f45 into trinodb:master May 11, 2022
@github-actions github-actions bot added this to the 381 milestone May 11, 2022
@ebyhr ebyhr mentioned this pull request May 11, 2022
Closed
@mosabua mosabua mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed docs
Milestone
381
Development

Successfully merging this pull request may close these issues.

Support dynamic loading of redis table description files
2 participants
@polaris6 @ebyhr