Add properties, requirements, and best practices from FTE blog #12231
Conversation
| @@ -49,7 +49,8 @@ execution on a Trino cluster: | |||
| * - ``exchange.deduplication-buffer-size`` | |||
| - Size of the coordinator's in-memory buffer used by fault-tolerant | |||
| execution to store output of query :ref:`stages <trino-concept-stage>`. | |||
| If this buffer is filled during query execution, the query fails unless | |||
| If this buffer is filled during query execution, the query fails with a | |||
| "Task descriptor storage capacity has been exceeded" error message unless | |||
There was a problem hiding this comment.
Should we use code highlighting for the error message?
There was a problem hiding this comment.
I worry it'll cause issues with SEO, which is the whole reason to have the full error text here.
|
|
||
| * Set the ``query.low-memory-killer.policy`` | ||
| :doc:`query management property </admin/properties-query-management>` to | ||
| ``total-reservation-on-blocked-nodes``, or queries may |
There was a problem hiding this comment.
This is the default, right?
There was a problem hiding this comment.
If the docs are correct, then yes. Still worth calling out I think, because it's a property that a reader might not associate with FTE and have configured differently.
|
|
||
| * The ``query.hash-partition-count`` :doc:`query management property | ||
| </admin/properties-query-management>` must be set to a value of ``50`` or | ||
| lower in ``config.properties``, as the filesystem exchanage manager supports |
There was a problem hiding this comment.
I'm thinking about introducing a dedicated property for fault tolerant execution with an appropriate default. The discussion is happening here: #12228 (comment)
jhlodin
force-pushed
the
jl/fte-blog-improvements
branch
from
4696714 to
8b5bf2b
Compare
jhlodin
force-pushed
the
jl/fte-blog-improvements
branch
from
8b5bf2b to
0b1db37
Compare
|
Added the new property from #12263 to this PR. @arhimondr |
|
Could we this merged with the code changes @arhimondr ? |
Description
Add new information gleaned from the Tardigrade blog post PR (trinodb/trino.io#287) to the documentation
Improvement
Documentation
Add new information to the fault-tolerant execution and query management properties documentation
Related issues, pull requests, and links
Incorporates information from trinodb/trino.io#287
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: