Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Trino workers in Web UI #12290

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

losipiuk
Copy link
Member

@losipiuk losipiuk commented May 9, 2022

Ensure stable sort order on "workers list" page in UI.
Previously order was changing on each page refresh.

Description

Is this change a fix, improvement, new feature, refactoring, or other?

improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

web ui

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Ensure stable sort order on "workers list" page in UI.
Previously order was changing on each page refresh.
@cla-bot cla-bot bot added the cla-signed label May 9, 2022
@losipiuk losipiuk requested review from findepi and arhimondr May 9, 2022 09:23
@findepi findepi added the ui Web UI label May 9, 2022
@losipiuk losipiuk merged commit aca4192 into trinodb:master May 9, 2022
@github-actions github-actions bot added this to the 381 milestone May 9, 2022
@mosabua
Copy link
Member

mosabua commented May 11, 2022

I think this is a minor user facing fix but it should be added to the release notes. I will add .. please confirm wording in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants