Fix LDAP Authenticator validation issues with ActiveDirectory service #12310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
changed the title
|
What does this change do? |
Praveen2112
changed the title
|
cc: @ajaytrivedi67. Can you please confirm from your side that this patch works for you. |
|
@findepi Have revisited the rationale |
Yes it's working for me |
kokosing
approved these changes
May 11, 2022
Previously we were trying to represent most of the operations via executeLdapSearch - so when we try to validatePassword, we login to the system and execute a query matching the user and query filter was on username. In case of OpenLDAP - the userName or distinguished name is of this format - uid=abc,...- which has an `=` and it is being treated as an equals filter condition when the filter expression is being parsed. While for AD the distinguished name is of this format abc@domain (if user is mapped based on UPN aka Unique Principal Name) not it is not a valid filter criteria, so we are not able to perform the validation.
Praveen2112
force-pushed
the
praveen/ldap_ad
branch
from
b483889 to
e2fe654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In regards with testing - There isn't any dockerized setup for ActiveDirectory (which uses UPN aka Unique Principal Name for login purpose) .. But have tested locally and it works as expected.
Fixes #12321.
This is specific to LDAP password authenticator.
This PR fixes LDAP Authenticator validation issues with ActiveDirectory
Related issues, pull requests, and links
#11909
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: