Properly handle failed attempts to delete a file in Hive connector #12314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
reviewed
May 10, 2022
| @@ -2247,7 +2248,10 @@ private void finishOptimize(ConnectorSession session, ConnectorTableExecuteHandl | |||
| if (firstScannedPath.isEmpty()) { | |||
| firstScannedPath = Optional.of(scannedPath); | |||
| } | |||
| retry().run("delete " + scannedPath, () -> fs.delete(scannedPath, false)); | |||
| retry().run("delete " + scannedPath, () -> { | |||
There was a problem hiding this comment.
Can we have an integration test based on minio showcasing this fix?
https://docs.min.io/docs/minio-multi-user-quickstart-guide.html
There was a problem hiding this comment.
Would be nice - but I do not have resources to do that.
There was a problem hiding this comment.
Also the tricky part is that this delete call spots themselves are in error handling code paths - which would make test setup cumbersome.
findepi
approved these changes
May 10, 2022
There was a problem hiding this comment.
LGTM but let's wait a bit in case ignoring delete status was deliberate. Let's give a chance for folks to chime in.
Relates to: #12306
"Fixes"?
If we want an exception - then yeah - I would say it fixes it.\
Actually no - different code path.
electrum
reviewed
May 10, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/FileSystemHelper.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/fix-delete-optimize
branch
from
3b76f9d to
3e58eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bugfix
Hive connector
Related issues, pull requests, and links
Relates to: #12306
Fixes: #12296
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: