Add function resolution to SPI #12588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
function-spi
branch
2 times, most recently
from
3fa986d to
103bc90
Compare
Does it allow implementing non-annotation-driven functions in a connector? |
|
@findepi yes |
dain
force-pushed
the
function-spi
branch
3 times, most recently
from
ea9f679 to
20e84e6
Compare
dain
force-pushed
the
function-spi
branch
2 times, most recently
from
b3d0fd0 to
865b1d5
Compare
martint
reviewed
Aug 30, 2022
core/trino-main/src/main/java/io/trino/metadata/QualifiedFunctionName.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/QualifiedFunctionName.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/FunctionBundle.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/ScalarImplementation.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/aggregation/ParametricAggregation.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/FunctionInvoker.java
Outdated
Show resolved
Hide resolved
martint
reviewed
Aug 31, 2022
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/GlobalFunctionCatalog.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/GlobalFunctionCatalog.java
Show resolved
Hide resolved
martint
approved these changes
Sep 1, 2022
Catalogs functions can be added via SET PATH. Builtin functions are always processed first.
This was referenced Sep 7, 2022
findepi
reviewed
Sep 20, 2022
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| @Experimental(eta = "2022-10-31") | ||
| public class QualifiedFunctionName |
There was a problem hiding this comment.
What's the difference between this class QualifiedFunctionName and io.trino.spi.expression.FunctionName?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the last step in adding dynamic function resolution to the SPI. The function system has been updated in previous PRs, and this PR is focused on:
Related issues, pull requests, and links
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(X) Release notes entries required with the following suggested text: