Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors caused by predicates pushdown on MongoDB JSON columns #13762

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

silly-carbon
Copy link
Member

@silly-carbon silly-carbon commented Aug 20, 2022

Description

Fix errors caused by predicates pushdown on MongoDB JSON columns

Is this change a fix, improvement, new feature, refactoring, or other?
fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
This is a change to the MongoDB connector only

How would you describe this change to a non-technical end user or system administrator?
The MongoDB connector no longer causes errors on predicates on JSON columns

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# MongoDB
* Fix failure for queries filtering on columns with `json` type. ({issue}`13536`)

@cla-bot
Copy link

cla-bot bot commented Aug 20, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the commit title and body to

Disable predicate pushdown on MongoDB json columns

The query failed when building MongoDB query.

@cla-bot
Copy link

cla-bot bot commented Aug 21, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@silly-carbon
Copy link
Member Author

@ebyhr Hello there, I've made some updates(according to your previous comments) to the code and wish to get your feedback😁

@cla-bot
Copy link

cla-bot bot commented Aug 22, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@silly-carbon silly-carbon requested a review from ebyhr August 23, 2022 01:36
@cla-bot
Copy link

cla-bot bot commented Aug 23, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@silly-carbon
Copy link
Member Author

@ebyhr Thanks for the comments, I've updated the code.

By the way, please take a look at the CLA mailbox, I believe I've sent a signed PDF 😁

@ebyhr
Copy link
Member

ebyhr commented Aug 30, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2022
@cla-bot
Copy link

cla-bot bot commented Aug 30, 2022

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr
Copy link
Member

ebyhr commented Aug 30, 2022

Could you confirm CI failures?

@silly-carbon
Copy link
Member Author

silly-carbon commented Aug 31, 2022

Could you confirm CI failures?

@ebyhr
Failures solved.

Made changes to io.trino.plugin.mongodb.MongoMetadata#applyFilter to explicitly distinguish between supported and unsupported types

The query failed when building MongoDB query.
@ebyhr ebyhr merged commit b57438a into trinodb:master Aug 31, 2022
@ebyhr
Copy link
Member

ebyhr commented Aug 31, 2022

Merged, thanks!

@ebyhr ebyhr mentioned this pull request Aug 31, 2022
@silly-carbon silly-carbon deleted the fix-mongo-json branch August 31, 2022 06:36
@github-actions github-actions bot added this to the 395 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Predicates on JSON column fails in MongoDB connector
2 participants