Simplify creation of join operator #13783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Aug 23, 2022
core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
Outdated
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/110-clean-up-join-hierarchy
branch
from
0dcd9d6 to
842304b
Compare
|
Made the changes you proposed. Indeed it is much more readable now |
|
Additionally, more lines are removed than added. |
sopel39
reviewed
Aug 30, 2022
core/trino-main/src/main/java/io/trino/operator/TrinoOperatorFactories.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/TrinoOperatorFactories.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/join/unspilled/JoinTestUtils.java
Outdated
Show resolved
Hide resolved
...-main/src/test/java/io/trino/operator/join/unspilled/BenchmarkHashBuildAndJoinOperators.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/110-clean-up-join-hierarchy
branch
from
842304b to
335b0a5
Compare
sopel39
reviewed
Aug 31, 2022
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Show resolved
Hide resolved
sopel39
reviewed
Aug 31, 2022
core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
Outdated
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/110-clean-up-join-hierarchy
branch
2 times, most recently
from
77ae5bf to
8285a1f
Compare
sopel39
approved these changes
Sep 5, 2022
core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
Outdated
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/110-clean-up-join-hierarchy
branch
from
8285a1f to
8068553
Compare
added 2 commits
September 5, 2022 18:59
This makes further refactorings easier to read.
Since the split into spilling and non-spilling, creation of join operators had some unnecessary casting. This commit cleans it and makes clear spilling/non-spilling code paths in LocalExecutionPlanner. Changes in this class are strictly mechanical. No logical changes are made.
skrzypo987
force-pushed
the
skrzypo/110-clean-up-join-hierarchy
branch
from
8068553 to
1c8f7c2
Compare
ssheikin
reviewed
Sep 6, 2022
| OptionalInt totalOperatorsCount, | ||
| PartitioningSpillerFactory partitioningSpillerFactory, | ||
| BlockTypeOperators blockTypeOperators); | ||
| public static class JoinOperatorType |
There was a problem hiding this comment.
Modifier 'public' is redundant for interface members
Modifier 'static' is redundant for inner classes of interfaces
There was a problem hiding this comment.
Thanks. I wonder why InteliJ did not notice this.
There was a problem hiding this comment.
I've InteliJ Ultimate - and it's not that I'm an eagle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactoring
core query engine
nothing worth mentioning
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: