Clean extension points for managing objects BaseJdbcClient #14458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
maintenance
findepi
force-pushed
the
findepi/jdbc-extensions
branch
from
57fc3f3 to
2fd10ff
Compare
The condition could be reached for the enclosed ALTER ... RENAME COLUMN statement, however the `execute(Connection, String)` method does not propagate the `SQLException`, so it is actually unreachable.
The caller has a `Connection` so it has to deal with `SQLException` anyway. This avoid premature wrapping of exceptions.
The extension point returning SQL query to execute is nice, but only works when the execution itself is always the same (e.g. no prepared statement parameters).
The extension point returning SQL query to execute is nice, but only works when the execution itself is always the same (e.g. no prepared statement parameters).
The extension point returning SQL query to execute is nice, but only works when the execution itself is always the same (e.g. no prepared statement parameters).
The extension point returning SQL query to execute is nice, but only works when the execution itself is always the same (e.g. no prepared statement parameters).
The extension point returning SQL query to execute is nice, but only works when the execution itself is always the same (e.g. no prepared statement parameters).
findepi
force-pushed
the
findepi/jdbc-extensions
branch
from
15b5513 to
5105358
Compare
ebyhr
approved these changes
Oct 5, 2022
vlad-lyutenko
approved these changes
Oct 5, 2022
hashhar
reviewed
Oct 6, 2022
| @@ -457,12 +457,12 @@ public void renameColumn(ConnectorSession session, JdbcTableHandle handle, JdbcC | |||
| quoted(newRemoteColumnName)); | |||
| execute(connection, sql); | |||
| } | |||
| catch (TrinoException e) { | |||
| catch (SQLSyntaxErrorException syntaxError) { | |||
There was a problem hiding this comment.
was confusion when I first read this - the change is equivalent because now the original exception gets thrown by execute instead of wrapped within TrinoException.
hashhar
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.