Make column masks insensitive to relation field order #15443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does it relate to #14420 ? Also, see my comments in that discussion about multiple masks for the same column: #14420 (comment) |
Oh, haven't seen this one. The code in this one is a combination of both, it attempts to create as few projections as possible, but retains support for multiple masks per field. It does that by combining all second masks into a second projection, third ones into third etc. |
|
@atanasenko there was a force push to the master branch (per #15365 (comment)), so your PR appears as if containing some unrelated commits. |
Changes the way column masks are applied from an incremental buildup of nested ProjectNode instances to a single projection for all fields. It's only when there are multiple masks for the same field will it nest multiple projections. This allows masks to reference original fields without interfering with each other as much as possible.
atanasenko
force-pushed
the
at/columnmask-field-order
branch
from
da56cf1 to
df1c76b
Compare
|
Closing in favor of #14420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the way column masks are applied from an incremental buildup of nested ProjectNode instances to a single projection for all fields. It's only when there are multiple masks for the same field will it nest multiple projections.
This allows masks to reference original fields without interfering with each other as much as possible.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: