Add table function for generating Iceberg CDC records #15677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jan 12, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergTableChangesFunction.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergTableChangesFunction.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergTableChangesFunction.java
Outdated
Show resolved
Hide resolved
alexjo2144
force-pushed
the
iceberg/cdc
branch
from
33ce25b to
4331ceb
Compare
|
Just a rebase to resolve conflicts. |
|
Now that the PTF SPI has solidified a bit I've reworked this PR to use it. Should look a lot like the Delta Lake one now |
homar
reviewed
Jun 22, 2023
.../main/java/io/trino/plugin/iceberg/functions/tablechanges/TableChangesFunctionProcessor.java
Outdated
Show resolved
Hide resolved
homar
reviewed
Jun 22, 2023
.../main/java/io/trino/plugin/iceberg/functions/tablechanges/TableChangesFunctionProcessor.java
Outdated
Show resolved
Hide resolved
homar
reviewed
Jun 22, 2023
...src/main/java/io/trino/plugin/iceberg/functions/tablechanges/TableChangesFunctionHandle.java
Outdated
Show resolved
Hide resolved
homar
reviewed
Jun 22, 2023
...-iceberg/src/main/java/io/trino/plugin/iceberg/functions/tablechanges/TableChangesSplit.java
Outdated
Show resolved
Hide resolved
homar
reviewed
Jun 22, 2023
...eberg/src/main/java/io/trino/plugin/iceberg/functions/tablechanges/TableChangesFunction.java
Outdated
Show resolved
Hide resolved
homar
reviewed
Jun 22, 2023
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Show resolved
Hide resolved
|
I think adding information about this to documentation will be nice |
...rg/src/main/java/io/trino/plugin/iceberg/functions/tablechanges/TableChangesSplitSource.java
Show resolved
Hide resolved
|
I'll work on some documentation for this tomorrow but I think the code should be pretty close to good. |
|
Per #17928 (review) using TableFunctionSplitProcessor may be a dead-end and it should be reserved for really cheap functions only. |
|
BTW the build didn't run due to conflicts. |
Adds a table function which, given a range of snapshot ids, will produce a table of the rows inserted and deleted between those two snapshots. Currently only supports metadata deletes, not merge-on-read positional or equality deletes.
alexjo2144
force-pushed
the
iceberg/cdc
branch
from
c60d4e0 to
a69ccd4
Compare
|
@homar please review @alexjo2144 please check the build |
homar
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a table function which, given a range of snapshot ids, will produce a table of the rows inserted and deleted between those two snapshots.
Currently only supports metadata deletes, not merge-on-read positional or equality deletes.
A document comparing the Iceberg and Delta Lake CDC implementations and how I think we should reconcile the differences is here.
Additional context and related issues
Support for positional and equality deletes depends on: apache/iceberg#6182
Release notes
This is still a draft
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: