Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerberos delegation support #17853

Merged

Conversation

vlad-lyutenko
Copy link
Contributor

@vlad-lyutenko vlad-lyutenko commented Jun 12, 2023

Adding constrained delegation support to trino JDBC driver

Now user can create GSSCredential on its own and just pass it as driver property to JDBC driver, smth like this:

Properties driverProperties = new Properties();
GSSCredential userCredential = [userCredential]
driverProperties.put("KerberosConstrainedDelegation", userCredential);
Connection conn = DriverManager.getConnection(CONNECTION_URI, driverProperties)

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

Adding constrained delegation support to trino JDBC driver

Now user can create GSSCredential on its own and just pass it as driver property to JDBC driver, smth like this:

Properties driverProperties = new Properties();
GSSCredential userCredential = [userCredential]
driverProperties.put("KerberosConstrainedDelegation", userCredential);
Connection conn = DriverManager.getConnection(CONNECTION_URI, driverProperties)
# Section
* Add constrained delegation support to Trino JDBC driver

@cla-bot cla-bot bot added the cla-signed label Jun 12, 2023
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Jun 12, 2023
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large change with no description, documentation changes, etc. Please explain the purpose of this change, the design, how users would use it, etc.

@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch 3 times, most recently from a4d7b99 to 5a31c40 Compare June 14, 2023 00:18
@vlad-lyutenko
Copy link
Contributor Author

This is a large change with no description, documentation changes, etc. Please explain the purpose of this change, the design, how users would use it, etc.

Some description added

@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch from 5a31c40 to d08a695 Compare June 14, 2023 09:16
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed it

@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch 2 times, most recently from 430aadf to df89dd6 Compare June 15, 2023 11:18
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch from df89dd6 to bddbfab Compare June 19, 2023 11:25
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch 8 times, most recently from 123640b to 89560e9 Compare June 27, 2023 18:41
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch from 995024f to 369d245 Compare June 29, 2023 10:25
@github-actions github-actions bot added the docs label Jun 29, 2023
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch 3 times, most recently from d255f0f to 9080e23 Compare June 29, 2023 15:53
@vlad-lyutenko
Copy link
Contributor Author

flaky #17436

@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch 2 times, most recently from 2152a1a to 4254edf Compare June 30, 2023 11:25
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

@Praveen2112
Copy link
Member

@electrum We have updated the docs and added description - Can you please take a look here ?

@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch 4 times, most recently from d53f200 to 6a4c8a7 Compare July 10, 2023 11:50
vlad-lyutenko and others added 2 commits July 11, 2023 14:46
Co-authored-by: Mateusz "Serafin" Gajewski <mateusz.gajewski@gmail.com>
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch from 6a4c8a7 to 4749dff Compare July 11, 2023 12:46
@Praveen2112
Copy link
Member

@mosabua Can you please take a look at the docs changes.

@Praveen2112
Copy link
Member

@electrum We have update the docs, description for the PR. Can you please take a look at this PR

@Praveen2112
Copy link
Member

@electrum We believe your feedback is addressed. We are about to merge this PR, so please let us know if you have any more comments

@Praveen2112 Praveen2112 requested a review from electrum July 14, 2023 10:26
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/kerberos-delegation branch from 4749dff to ba9eeba Compare July 17, 2023 14:03
@Praveen2112 Praveen2112 merged commit 8af0d22 into trinodb:master Jul 17, 2023
@Praveen2112
Copy link
Member

@vlad-lyutenko Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants