-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerberos delegation support #17853
Kerberos delegation support #17853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large change with no description, documentation changes, etc. Please explain the purpose of this change, the design, how users would use it, etc.
a4d7b99
to
5a31c40
Compare
Some description added |
5a31c40
to
d08a695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed it
client/trino-jdbc/src/main/java/io/trino/jdbc/AbstractConnectionProperty.java
Show resolved
Hide resolved
client/trino-jdbc/src/main/java/io/trino/jdbc/AbstractConnectionProperty.java
Outdated
Show resolved
Hide resolved
430aadf
to
df89dd6
Compare
client/trino-jdbc/src/test/java/io/trino/jdbc/TestTrinoDriver.java
Outdated
Show resolved
Hide resolved
client/trino-jdbc/src/main/java/io/trino/jdbc/ConnectionProperties.java
Outdated
Show resolved
Hide resolved
client/trino-client/src/main/java/io/trino/client/auth/kerberos/GSSContextProvider.java
Show resolved
Hide resolved
...lient/src/main/java/io/trino/client/auth/kerberos/DelegatedUnconstrainedContextProvider.java
Outdated
Show resolved
Hide resolved
...-client/src/main/java/io/trino/client/auth/kerberos/DelegatedConstrainedContextProvider.java
Outdated
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Outdated
Show resolved
Hide resolved
df89dd6
to
bddbfab
Compare
client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoDriverUri.java
Outdated
Show resolved
Hide resolved
...lient/src/main/java/io/trino/client/auth/kerberos/DelegatedUnconstrainedContextProvider.java
Show resolved
Hide resolved
client/trino-client/src/main/java/io/trino/client/OkHttpUtil.java
Outdated
Show resolved
Hide resolved
...-client/src/main/java/io/trino/client/auth/kerberos/DelegatedConstrainedContextProvider.java
Outdated
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Outdated
Show resolved
Hide resolved
...-client/src/main/java/io/trino/client/auth/kerberos/DelegatedConstrainedContextProvider.java
Outdated
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Show resolved
Hide resolved
123640b
to
89560e9
Compare
995024f
to
369d245
Compare
d255f0f
to
9080e23
Compare
flaky #17436 |
...lient/src/main/java/io/trino/client/auth/kerberos/DelegatedUnconstrainedContextProvider.java
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Outdated
Show resolved
Hide resolved
.../java/io/trino/tests/product/launcher/env/environment/EnvMultinodeTlsKerberosDelegation.java
Outdated
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Outdated
Show resolved
Hide resolved
2152a1a
to
4254edf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits
client/trino-client/src/main/java/io/trino/client/auth/kerberos/BaseGSSContextProvider.java
Outdated
Show resolved
Hide resolved
client/trino-client/src/main/java/io/trino/client/OkHttpUtil.java
Outdated
Show resolved
Hide resolved
...-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/HadoopKerberos.java
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Outdated
Show resolved
Hide resolved
...t-tests/src/main/java/io/trino/tests/product/jdbc/TestKerberosConstrainedDelegationJdbc.java
Show resolved
Hide resolved
@electrum We have updated the docs and added description - Can you please take a look here ? |
d53f200
to
6a4c8a7
Compare
Co-authored-by: Mateusz "Serafin" Gajewski <mateusz.gajewski@gmail.com>
6a4c8a7
to
4749dff
Compare
@mosabua Can you please take a look at the docs changes. |
@electrum We have update the docs, description for the PR. Can you please take a look at this PR |
@electrum We believe your feedback is addressed. We are about to merge this PR, so please let us know if you have any more comments |
Co-authored-by: Mateusz "Serafin" Gajewski <mateusz.gajewski@gmail.com>
4749dff
to
ba9eeba
Compare
@vlad-lyutenko Thanks for working on this. |
Adding constrained delegation support to trino JDBC driver
Now user can create GSSCredential on its own and just pass it as driver property to JDBC driver, smth like this:
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Adding constrained delegation support to trino JDBC driver
Now user can create GSSCredential on its own and just pass it as driver property to JDBC driver, smth like this: