Change Hive CSV escape character to backslash when set to double quote #18952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Sep 7, 2023
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/line/csv/CsvDeserializerFactory.java
Outdated
Show resolved
Hide resolved
Hive has a bug that changes the escape character to backslash when it is explicitly set to a double quote during deserialization. The native CSV reader is a bug for bug compatible reimplementation of the Hive OpenCSV reader, so this behavior must be replicated.
|
I'm very amused by the prospect of having to intentionally add a bug in for compatibility purposes. I totally get it, it's just a funny principle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hive has a bug that changes the escape character to backslash when it is explicitly set to a double quote during deserialization. The native CSV reader is a bug for bug compatible reimplementation of the Hive OpenCSV reader, so this behavior must be replicated.
Fixes #18918
Release notes
(X) Release notes are required, with the following suggested text: