Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove split when finished #18958

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Remove split when finished #18958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...main/src/main/java/io/trino/execution/executor/dedicated/ThreadPerDriverTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,12 @@ public synchronized List<ListenableFuture<Void>> enqueueSplits(TaskHandle handle

int splitId = entry.nextSplitId();
ListenableFuture<Void> done = scheduler.submit(entry.group(), splitId, new VersionEmbedderBridge(versionEmbedder, new SplitProcessor(entry.taskId(), splitId, split, tracer)));
done.addListener(split::close, directExecutor());
done.addListener(
() -> {
split.close();
entry.removeSplit(split);
},
directExecutor());
futures.add(done);
}

Expand Down Expand Up @@ -173,6 +178,8 @@ public synchronized void destroy()
for (SplitRunner split : splits) {
split.close();
}

splits.clear();
}

public synchronized void addSplit(SplitRunner split)
Expand All @@ -181,6 +188,11 @@ public synchronized void addSplit(SplitRunner split)
splits.add(split);
}

public void removeSplit(SplitRunner split)
{
splits.remove(split);
}

public int nextSplitId()
{
return nextSplitId.incrementAndGet();
Expand Down