Use fully qualified functions in planner and optimizer #19035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
resolve-functions
branch
2 times, most recently
from
356ab3c to
452135e
Compare
electrum
approved these changes
Sep 15, 2023
core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/ResolvedFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/ResolvedFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/annotations/ImplementationDependency.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/FormatFunction.java
Outdated
Show resolved
Hide resolved
| return FunctionCallBuilder.resolve(session, metadata) | ||
| .setName(QualifiedName.of(nullAllowed ? NullableFunction.NAME : Function.NAME)) | ||
| return BuiltinFunctionCallBuilder.resolve(metadata) | ||
| .setName(nullAllowed ? NullableFunction.NAME : Function.NAME) |
There was a problem hiding this comment.
We should rename Function to DynamicFilterFunction
core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/ExtractSpatialJoins.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/ResolvedFunction.java
Outdated
Show resolved
Hide resolved
| @@ -45,7 +69,10 @@ public void testPruneOneChild() | |||
| p.values(a, unused), | |||
| p.values(b, r), | |||
| ImmutableList.of(a, b, r), | |||
| expression("ST_Distance(a, b) <= r")); | |||
There was a problem hiding this comment.
Can we handle this by adding a rewriteFunctionCall to io.trino.sql.ExpressionUtils#rewriteIdentifiersToSymbolReferences?
There was a problem hiding this comment.
It is possible, but after talking with Martin he wants to move away from this method. This change sets up the code for the new IR.
Use TranslationMap to apply casts, desugar expression, and preform other rewrites in evaluateConstantExpression
Move CatalogSchemaFunctionName to SPI and add to BoundSignature
Operators and coercions must be global functions
Most uses of resolve function in analyzer and optimizers are hard coded to lookup builtin functions, and these can use the simpler resolveBuiltin method that does not need a session. Split FunctionCallBuilder into BuiltinFunctionCallBuilder for building new function call nodes for builtin functions, and ResolvedFunctionCallBuilder for building a function call node for previously resolved function.
dain
force-pushed
the
resolve-functions
branch
from
452135e to
503fd2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the planner and optimizer to consistenly handle fully qualified function names. To reduce the burden on this code this PR adds a simplified method to resolve builtin functions. This new function uses a simple string function name, and removes the need for a session, as session was only need for PATH.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.