Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hive label to trino-filesystem-* changes #19039

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 14, 2023

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the hive label for?

can we add iceberg label as well?

@hashhar
Copy link
Member

hashhar commented Sep 15, 2023

IMO wouldn't it be better to just add a single label test-with-secrets (or something which conveys that the PR needs to be tested with secrets) instead of labels which just say what module is affected?

@hashhar
Copy link
Member

hashhar commented Sep 15, 2023

what is the hive label for?

Nothing, it's just information. The only functional labels we have today are:

tests:all
tests:all-product
product-tests:all
tests:hive

(search for labels.*.name in ci.yml to find this list)

@wendigo wendigo merged commit 76d9b01 into trinodb:master Sep 19, 2023
@wendigo wendigo deleted the serafin/hive-labels branch September 19, 2023 06:57
@github-actions github-actions bot added this to the 427 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants