Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve printing of join criteria in PlanPrinter #19041

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

raunaqmorarka
Copy link
Member

Description

Print join criteria and filter separately for clarity

Additional context and related issues

e.g.

LeftJoin[criteria = ("custkey" = "custkey_2"), filter = ("orderdate_5" BETWEEN date_add('day', BIGINT '-30', "orderdate") AND "orderdate"), hash = [$hashvalue_11, $hashvalue_13], distribution = PARTITIONED]

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@lukasz-stec lukasz-stec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could add explain tests. make sure automation passes (there might be test already)

@raunaqmorarka
Copy link
Member Author

unrelated failure #19045

@wendigo
Copy link
Contributor

wendigo commented Sep 14, 2023

@raunaqmorarka unrelated failure is resolved now

Print join criteria and filter separately for clarity
@raunaqmorarka raunaqmorarka merged commit 0c6fac4 into trinodb:master Sep 15, 2023
@raunaqmorarka raunaqmorarka deleted the join-print branch September 15, 2023 03:32
@github-actions github-actions bot added this to the 427 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants