Skip dropping testing Glue database when create time is within threshold #19101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
test
no-release-notes
ebyhr
force-pushed
the
ebi/delta-cleanup-schema
branch
from
8f18f51 to
0ffb20d
Compare
ebyhr
changed the title
findepi
reviewed
Sep 20, 2023
| try { | ||
| onTrino().executeQuery("DROP SCHEMA IF EXISTS " + schema); | ||
| log.info("Dropped schema %s", schema); | ||
| if (createTime.isBefore(SCHEMA_CLEANUP_THRESHOLD)) { |
There was a problem hiding this comment.
If we are not going to delete the schema, we should also abstain from deleting tables in that schema
ebyhr
force-pushed
the
ebi/delta-cleanup-schema
branch
from
0ffb20d to
32f2fff
Compare
findinpath
approved these changes
Sep 20, 2023
findinpath
approved these changes
Sep 20, 2023
findepi
approved these changes
Sep 20, 2023
| @@ -69,6 +71,12 @@ public void testCleanUpOldTablesUsingDelta() | |||
|
|
|||
| private void cleanSchema(String schema, long startTime, AWSGlueAsync glueClient) | |||
| { | |||
| Database database = glueClient.getDatabase(new GetDatabaseRequest().withName(schema)).getDatabase(); | |||
| if (database.getCreateTime().toInstant().isAfter(SCHEMA_CLEANUP_THRESHOLD)) { | |||
There was a problem hiding this comment.
nit, pre-existing, SCHEMA_CLEANUP_THRESHOLD shouldn't be a static constant
it doesn't matter when class was loaded in current JVM. it matters when cleanup code was invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I suppose TestDatabricksWithGlueMetastoreCleanUp affected TestIcebergGlueCatalogAccessOperations.
There were many Glue
DeleteDatabasecalls in CloudTrail when TestIcebergGlueCatalogAccessOperations was running.Fixes #19100
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.